Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in extension path: Activation Environment tests failing #14163

Closed
rchiodo opened this issue Sep 29, 2020 · 1 comment
Closed

Space in extension path: Activation Environment tests failing #14163

rchiodo opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@rchiodo
Copy link

rchiodo commented Sep 29, 2020

Error when extension has space in path:

  1. Activation of Environments in Terminal
    Should not activate:
    Error: /home/runner/work/vscode-python/vscode-python/path with spaces/src/testMultiRootWkspc/smokeTests/testExecInTerminal_3.log file not created.
    at Timeout. (out/test/common.js:325:20)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)

  2. Activation of Environments in Terminal
    Should activate with pipenv:
    Error: /home/runner/work/vscode-python/vscode-python/path with spaces/src/testMultiRootWkspc/smokeTests/testExecInTerminal_8.log file not created.
    at Timeout. (out/test/common.js:325:20)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)

  3. Activation of Environments in Terminal
    Should activate with virtualenv:
    Error: /home/runner/work/vscode-python/vscode-python/path with spaces/src/testMultiRootWkspc/smokeTests/testExecInTerminal_12.log file not created.
    at Timeout. (out/test/common.js:325:20)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)

  4. Activation of Environments in Terminal
    Should activate with conda:
    Error: /home/runner/work/vscode-python/vscode-python/path with spaces/src/testMultiRootWkspc/smokeTests/testExecInTerminal_16.log file not created.
    at Timeout. (out/test/common.js:325:20)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)

Steps to repro:

  1. Git clone with a space in the path
  2. Run the appropriate tests

If that doesn't repro, then try using a github action to repro. See this PR:
#14113

@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team important Issue identified as high-priority labels Sep 29, 2020
@rchiodo
Copy link
Author

rchiodo commented Sep 29, 2020

Adding P1 per Brett's comments.

@karthiknadig karthiknadig added needs PR area-internal Label for non-user facing issues labels Sep 30, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 30, 2020
@kimadeline kimadeline self-assigned this Oct 1, 2020
@ghost ghost removed the needs PR label Oct 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants