Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launch.json schema to add "python" and remove "pythonPath" #12462

Closed
int19h opened this issue Jun 19, 2020 · 1 comment · Fixed by #14676
Closed

Update launch.json schema to add "python" and remove "pythonPath" #12462

int19h opened this issue Jun 19, 2020 · 1 comment · Fixed by #14676
Assignees
@int19h
Labels
area-debugging feature-request Request for new features or functionality

Comments

@int19h
Copy link

int19h commented Jun 19, 2020

Now that we no longer have to worry about debug configs being compatible with both ptvsd and debugpy, there's no reason to use the legacy spelling and semantics for the property. The schema should be updated:

  1. Remove "pythonPath" entirely.

  2. Add "python", and reflect the fact that it can be either a simple string, or an array of strings (to specify command-line arguments for the Python interpreter itself).
@int19h int19h added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jun 19, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 22, 2020
@int19h
Copy link
Author

int19h commented Jul 31, 2020

#13218 is now intended as the one and only way of supplying arguments to the interpreter, so "python": [...] shouldn't be exposed in the extension - only scalar string values.

(debugpy will still support the array syntax for backwards compatibility)

@int19h int19h mentioned this issue Aug 12, 2020
Closed
@int19h int19h mentioned this issue Nov 9, 2020
Closed
int19h added a commit to int19h/vscode-python that referenced this issue Nov 9, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher
ae5120a 
Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Properly register the python.interpreterPath command to expand the ${command:interpreterPath} debug configuration variable.

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath" and/or "${command:python.interpreterPath}".
int19h added a commit to int19h/vscode-python that referenced this issue Nov 9, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher
558e983 
Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Properly register the python.interpreterPath command to expand the ${command:interpreterPath} debug configuration variable.

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath" and/or "${command:python.interpreterPath}".
@int19h int19h mentioned this issue Nov 9, 2020
Merged
10 tasks
int19h added a commit to int19h/vscode-python that referenced this issue Nov 9, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher
eb85b48 
Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Properly register the python.interpreterPath command to expand the ${command:interpreterPath} debug configuration variable.

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath" and/or "${command:python.interpreterPath}".
int19h added a commit to int19h/vscode-python that referenced this issue Nov 9, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher
bb1067d 
Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Properly register the python.interpreterPath command to expand the ${command:interpreterPath} debug configuration variable.

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath" and/or "${command:python.interpreterPath}".
int19h added a commit to int19h/vscode-python that referenced this issue Nov 10, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher
0386fed 
Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".
int19h pushed a commit that referenced this issue Nov 16, 2020
Fix #14674: Enable overriding "pythonPath" in the launcher (#14676)
4e45a4d 
Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".
@ghost ghost removed the needs PR label Nov 16, 2020
int19h pushed a commit to int19h/vscode-python that referenced this issue Nov 16, 2020
@int19h
Fix microsoft#14674: Enable overriding "pythonPath" in the launcher (m…
0d995b5 
…icrosoft#14676)

Fix microsoft#12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".
int19h pushed a commit that referenced this issue Nov 16, 2020
Fix #14674: Enable overriding "pythonPath" in the launcher
dfd7cf1 
Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".
@ShadiestGoat ShadiestGoat mentioned this issue Nov 22, 2020
Closed
karthiknadig added a commit that referenced this issue Nov 26, 2020
@karthiknadig @joyceerhl @jakebailey
Merge back from release to main (#14758)
850de71 
* Cherry pick from main (#14644)

* Update shipped wheels version (#14615)

* Update shipped wheels version

* News item

* Remove redundant files (#14620)

* Add extension dependencies at build time (#14636)

* Use Node 12.15 in Insiders and Release GitHub Actions (#14641)

* Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642)

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>

* Cherry pic fixes into release for tests. (#14673)

* Added FSWatching base class and made related changes (#14605)

* Add FSWatching locator base class

* Correct glob pattern to not match python3.2whoa

* Add documentation of python binary watcher

* Fix lint errors

* Update ignore list

* Add disposable registry

* Modify FSWatching Locator

* Code reviews

* Use string[]

* Remove list disposable getter

* Fix failing global virtual env watcher tests (#14633)

Co-authored-by: Kartik Raj <karraj@microsoft.com>

* Version, change log and cherrypicks for nov release (#14696)

* change log updates

* Update gifs

* Fix for interpreter selection (#14693)

* Fix for interpreter selection

* Fix linting errors

* Minor tweak to property removal

* Cherry pick "Bind function to correct this for workspace syms" (#14743)

* Fix #14674: Enable overriding "pythonPath" in the launcher

Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".

* Point release change log and version update (#14750)

* Point release change log and version update

* Fix process picker (#14700)

* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode

* update change log with cherry pick

Co-authored-by: Kartik Raj <karraj@microsoft.com>

Co-authored-by: Joyce Er <joyceerhuiling@gmail.com>
Co-authored-by: Kartik Raj <karraj@microsoft.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Pavel Minaev <pminaev@microsoft.com>
br3ndonland added a commit to br3ndonland/inboard that referenced this issue Dec 20, 2020
@br3ndonland
Update VSCode debugger config for new Python key
3882828 
microsoft/vscode-python#12462
https://github.com/microsoft/vscode-python/releases/tag/2020.11.367453362

`pythonPath` -> `python`
@luabud luabud mentioned this issue Jan 18, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@int19h int19h

Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #12462, #14674 for debugging int19h/vscode-python
3 participants
@int19h @karthiknadig @luabud