Use correct tsconfig.json when generating npm package (#21651)

For #21631 

- Unset `removeComment` as that leads to declarations without docstrings
- Set to generate declarations
- Use updated typescript which results in cleaner declaration files

pythonExtensionApi/.eslintrc

@@ -0,0 +1,8 @@
+{
+    "rules": {
+        "padding-line-between-statements": [
+            "error",
+            { "blankLine": "always", "prev": "export", "next": "*" }
+        ]
+    }
+}

pythonExtensionApi/README.md

@@ -28,6 +28,8 @@ The actual source code to get the active environment to run some script could lo
 // Import the API
 import { PythonExtension } from '@vscode/python-extension';
 
+...
+
 // Load the Python extension API
 const pythonApi: PythonExtension = await PythonExtension.api();
 

pythonExtensionApi/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@vscode/python-extension",
     "description": "An API facade for the Python extension in VS Code",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "author": {
       "name": "Microsoft Corporation"
     },
@@ -28,13 +28,17 @@
     "dependencies": {
         "@types/vscode": "^1.78.0"
     },
+    "devDependencies": {
+        "typescript": "5.0.4"
+    },
     "scripts": {
         "prepublishOnly": "echo \"⛔ Can only publish from a secure pipeline ⛔\" && node ../build/fail",
 		"prepack": "npm run all:publish",
-		"compile": "node ../node_modules/typescript/lib/tsc.js -b ./tsconfig.json",
+		"compile": "node ./node_modules/typescript/lib/tsc.js -b ./tsconfig.json",
 		"clean": "node ../node_modules/rimraf/bin.js out",
 		"lint": "node ../node_modules/eslint/bin/eslint.js --ext ts src",
 		"all": "npm run clean && npm run compile",
-		"all:publish": "git clean -xfd . && npm install && npm run compile"
+        "formatTypings": "node ../node_modules/eslint/bin/eslint.js --fix ./out/main.d.ts",
+		"all:publish": "git clean -xfd . && npm install && npm run compile && npm run formatTypings"
     }
 }

pythonExtensionApi/src/main.ts

@@ -316,6 +316,7 @@ export type EnvironmentPath = {
  * was contributed.
  */
 export type EnvironmentTools = KnownEnvironmentTools | string;
+
 /**
  * Tools or plugins the Python extension currently has built-in support for. Note this list is expected to shrink
  * once tools have their own separate extensions.
@@ -334,6 +335,7 @@ export type KnownEnvironmentTools =
  * Type of the environment. It can be {@link KnownEnvironmentTypes} or custom string which was contributed.
  */
 export type EnvironmentType = KnownEnvironmentTypes | string;
+
 /**
  * Environment types the Python extension is aware of. Note this list is expected to shrink once tools have their
  * own separate extensions, in which case they're expected to provide the type themselves.
@@ -392,6 +394,9 @@ export const PVSC_EXTENSION_ID = 'ms-python.python';
 
 // eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace PythonExtension {
+    /**
+     * Returns the API exposed by the Python extension in VS Code.
+     */
     export async function api(): Promise<PythonExtension> {
         const extension = extensions.getExtension(PVSC_EXTENSION_ID);
         if (extension === undefined) {

pythonExtensionApi/tsconfig.json

@@ -25,7 +25,7 @@
         "noUnusedParameters": true,
         "noFallthroughCasesInSwitch": true,
         "resolveJsonModule": true,
-        "removeComments": true
+        "declaration": true
     },
     "exclude": [
         "node_modules",