Added tests

microsoft · Apr 20, 2020 · e65ec36 · e65ec36
1 parent f7f3ade
commit e65ec36
Show file tree

Hide file tree

Showing 3 changed files with 360 additions and 42 deletions.
diff --git a/src/client/interpreter/configuration/interpreterSelector.ts b/src/client/interpreter/configuration/interpreterSelector.ts
@@ -24,10 +24,10 @@ import {
     IInterpreterComparer,
     IInterpreterQuickPickItem,
     IInterpreterSelector,
+    InterpreterStateArgs,
     IPythonPathUpdaterServiceManager
 } from './types';
 
-type InterpreterStateArgs = { path?: string; workspace: Resource };
 @injectable()
 export class InterpreterSelector implements IInterpreterSelector {
     private disposables: Disposable[] = [];
@@ -105,10 +105,10 @@ export class InterpreterSelector implements IInterpreterSelector {
 
         if (selection === undefined) {
             return;
-        } else if (selection !== enterInterpreterPathSuggestion) {
-            state.path = (selection as IInterpreterQuickPickItem).path;
+        } else if (selection.label === enterInterpreterPathSuggestion.label) {
+            return this._enterOrBrowseInterpreterPath(input, state);
         } else {
-            return this._enterOrBrowseInterpreterPath.bind(this);
+            state.path = (selection as IInterpreterQuickPickItem).path;
         }
     }
 
@@ -129,7 +129,9 @@ export class InterpreterSelector implements IInterpreterSelector {
             acceptFilterBoxTextAsSelection: true
         });
 
-        if (typeof selection === 'string') {
+        if (selection === undefined) {
+            return;
+        } else if (typeof selection === 'string') {
             // User entered text in the filter box to enter path to python, store it
             state.path = selection;
         } else if (selection.label === 'Browse...') {

diff --git a/src/client/interpreter/configuration/types.ts b/src/client/interpreter/configuration/types.ts
@@ -44,3 +44,5 @@ export const IInterpreterComparer = Symbol('IInterpreterComparer');
 export interface IInterpreterComparer {
     compare(a: PythonInterpreter, b: PythonInterpreter): number;
 }
+
+export type InterpreterStateArgs = { path?: string; workspace: Resource };