Revert pipenv activation to not use pipenv shell (#4406)

* reverted * news entry * CI coorected
microsoft · Feb 15, 2019 · d30269b · d30269b
1 parent fac5cc8
commit d30269b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/news/2 Fixes/4394.md b/news/2 Fixes/4394.md
@@ -0,0 +1 @@
+Revert pipenv activation to not use `pipenv shell`
diff --git a/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts b/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts
@@ -5,6 +5,7 @@
 
 import { inject, injectable } from 'inversify';
 import { Uri } from 'vscode';
+import '../../../common/extensions';
 import { IInterpreterService, InterpreterType, IPipEnvService } from '../../../interpreter/contracts';
 import { IWorkspaceService } from '../../application/types';
 import { IFileSystem } from '../../platform/types';
@@ -20,7 +21,7 @@ export class PipEnvActivationCommandProvider implements ITerminalActivationComma
     ) { }
 
     public isShellSupported(_targetShell: TerminalShellType): boolean {
-        return true;
+        return false;
     }
 
     public async getActivationCommands(resource: Uri | undefined, _: TerminalShellType): Promise<string[] | undefined> {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Revert pipenv activation to not use `pipenv shell`