When using pipenv, install packages (such as linters, test frameworks…

…) in dev-packages Fixes #1110
microsoft · Mar 21, 2018 · 7c3ff8a · 7c3ff8a
1 parent 2b4a246
commit 7c3ff8a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/news/1 Enhancements/1110.md b/news/1 Enhancements/1110.md
@@ -0,0 +1 @@
+When using pipenv, install packages (such as linters, test frameworks) in dev-packages.
diff --git a/src/client/common/installer/pipEnvInstaller.ts b/src/client/common/installer/pipEnvInstaller.ts
@@ -27,7 +27,7 @@ export class PipEnvInstaller implements IModuleInstaller {
 
     public installModule(name: string): Promise<void> {
         const terminalService = this.serviceContainer.get<ITerminalServiceFactory>(ITerminalServiceFactory).getTerminalService();
-        return terminalService.sendCommand(pipenvName, ['install', name]);
+        return terminalService.sendCommand(pipenvName, ['install', name, '--dev']);
     }
 
     public async isSupported(resource?: Uri): Promise<boolean> {

diff --git a/src/test/common/moduleInstaller.test.ts b/src/test/common/moduleInstaller.test.ts
@@ -200,7 +200,7 @@ suite('Module Installer', () => {
 
         let argsSent: string[] = [];
         mockTerminalService
-            .setup(async t => await t.sendCommand(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()))
+            .setup(t => t.sendCommand(TypeMoq.It.isAnyString(), TypeMoq.It.isAny()))
             .returns((cmd: string, args: string[]) => { argsSent = args; return Promise.resolve(void 0); });
         await pipInstaller.installModule(moduleName);
 
@@ -255,6 +255,6 @@ suite('Module Installer', () => {
         await pipInstaller.installModule(moduleName);
 
         expect(command!).equal('pipenv', 'Invalid command sent to terminal for installation.');
-        expect(argsSent.join(' ')).equal(`install ${moduleName}`, 'Invalid command arguments sent to terminal for installation.');
+        expect(argsSent.join(' ')).equal(`install ${moduleName} --dev`, 'Invalid command arguments sent to terminal for installation.');
     });
 });
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		When using pipenv, install packages (such as linters, test frameworks) in dev-packages.