remove unnecessary logging of error (#871)

Fixes #236
microsoft · Feb 22, 2018 · 58be8f8 · 58be8f8
1 parent 5bc6c1c
commit 58be8f8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/client/interpreter/locators/services/condaService.ts b/src/client/interpreter/locators/services/condaService.ts
@@ -74,7 +74,6 @@ export class CondaService implements ICondaService {
             // Failed because either:
             //   1. conda is not installed.
             //   2. `conda info --json` has changed signature.
-            this.logger.logError('Failed to get conda info from conda', ex);
         }
     }
     /**

diff --git a/src/test/interpreters/condaService.test.ts b/src/test/interpreters/condaService.test.ts
@@ -19,15 +19,14 @@ const environmentsPath = path.join(__dirname, '..', '..', '..', 'src', 'test', '
 
 // tslint:disable-next-line:max-func-body-length
 suite('Interpreters Conda Service', () => {
-    let logger: TypeMoq.IMock<ILogger>;
     let processService: TypeMoq.IMock<IProcessService>;
     let platformService: TypeMoq.IMock<IPlatformService>;
     let condaService: CondaService;
     let fileSystem: TypeMoq.IMock<IFileSystem>;
     let registryInterpreterLocatorService: TypeMoq.IMock<IInterpreterLocatorService>;
     let serviceContainer: TypeMoq.IMock<IServiceContainer>;
     setup(async () => {
-        logger = TypeMoq.Mock.ofType<ILogger>();
+        const logger = TypeMoq.Mock.ofType<ILogger>();
         processService = TypeMoq.Mock.ofType<IProcessService>();
         platformService = TypeMoq.Mock.ofType<IPlatformService>();
         registryInterpreterLocatorService = TypeMoq.Mock.ofType<IInterpreterLocatorService>();
@@ -391,7 +390,6 @@ suite('Interpreters Conda Service', () => {
 
         const condaInfo = await condaService.getCondaInfo();
         assert.equal(condaInfo, undefined, 'Conda info does not match');
-        logger.verify(l => l.logError(TypeMoq.It.isAny(), TypeMoq.It.isAny()), TypeMoq.Times.once());
     });
 
     test('Returns conda environments when conda exists', async () => {
@@ -453,7 +451,6 @@ suite('Interpreters Conda Service', () => {
 
         const condaInfo = await condaService.getCondaInfo();
         assert.equal(condaInfo, undefined, 'Conda info does not match');
-        logger.verify(l => l.logError(TypeMoq.It.isAny(), TypeMoq.It.isAny()), TypeMoq.Times.once());
     });
 
     test('Must use Conda env from Registry to locate conda.exe', async () => {