Skip to content

Commit

Permalink
Code reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
Kartik Raj committed Aug 30, 2023
1 parent d204bc1 commit 3cba9aa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

import { inject, injectable } from 'inversify';
import { Uri } from 'vscode';
import { Uri, l10n } from 'vscode';
import * as path from 'path';
import { IActiveResourceService, IApplicationShell, ITerminalManager } from '../../common/application/types';
import {
Expand Down Expand Up @@ -91,10 +91,10 @@ function getPromptName(interpreter?: PythonEnvironment) {
return '';
}
if (interpreter.envName) {
return `, i.e "(${interpreter.envName})"`;
return `, ${l10n.t('i.e')} "(${interpreter.envName})"`;
}
if (interpreter.envPath) {
return `, i.e "(${path.basename(interpreter.envPath)})"`;
return `, ${l10n.t('i.e')} "(${path.basename(interpreter.envPath)})"`;
}
return '';
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'use strict';

import { mock, when, anything, instance, verify, reset } from 'ts-mockito';
import { EventEmitter, Terminal, Uri } from 'vscode';
import { EventEmitter, Terminal, Uri, l10n } from 'vscode';
import { IActiveResourceService, IApplicationShell, ITerminalManager } from '../../../client/common/application/types';
import {
IConfigurationService,
Expand Down Expand Up @@ -35,7 +35,7 @@ suite('Terminal Environment Variable Collection Prompt', () => {
let interpreterService: IInterpreterService;
const prompts = [Common.doNotShowAgain];
const envName = 'env';
const expectedMessage = Interpreters.terminalEnvVarCollectionPrompt.format(`, i.e "(${envName})"`);
const expectedMessage = Interpreters.terminalEnvVarCollectionPrompt.format(`, ${l10n.t('i.e')} "(${envName})"`);

setup(async () => {
shell = mock<IApplicationShell>();
Expand Down

0 comments on commit 3cba9aa

Please sign in to comment.