Skip to content

Commit

Permalink
Fixed a bug where pylance not working on interactive window. (#20831)
Browse files Browse the repository at this point in the history
https://github.com/microsoft/vscode-python/pull/20816/files#diff-ba59d9ca0a087381d63119a88751fdc7c0aa07e6a10e772d3aefd4c10aa36fcfL47

this should have changed to return `false` rather than deleting since it
would have been always return `false`. deleting effectively made it to
have the same effect as always returning `true`

follow up PR of #20816
  • Loading branch information
heejaechang authored Mar 10, 2023
1 parent d3dd832 commit 2cd2092
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/client/activation/languageClientMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class LanguageClientMiddleware extends LanguageClientMiddlewareBase {
);
}

private shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean {
protected shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean {
return jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled;
}

Expand Down
5 changes: 5 additions & 0 deletions src/client/activation/node/languageClientMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ export class NodeLanguageClientMiddleware extends LanguageClientMiddleware {
}
}

// eslint-disable-next-line class-methods-use-this
protected shouldCreateHidingMiddleware(_: IJupyterExtensionDependencyManager): boolean {
return false;
}

protected async onExtensionChange(jupyterDependencyManager: IJupyterExtensionDependencyManager): Promise<void> {
if (jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled) {
await this.lspNotebooksExperiment.onJupyterInstalled();
Expand Down

0 comments on commit 2cd2092

Please sign in to comment.