Skip to content

Commit

Permalink
Fix debugger attach to process when running on WSL (#20741)
Browse files Browse the repository at this point in the history
Possible fix for #16921

Closes #16921

BTW you folks should probably ask GitHub support to eject this repo from
their original repository (so it stops being a fork and has its own
network on GH)
  • Loading branch information
JCMais authored Feb 27, 2023
1 parent e9dba6c commit 29bee00
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/client/common/process/rawProcessApis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import { noop } from '../utils/misc';
import { decodeBuffer } from './decoder';
import { traceVerbose } from '../../logging';

const PS_ERROR_SCREEN_BOGUS = /your [0-9]+x[0-9]+ screen size is bogus\. expect trouble/;

function getDefaultOptions<T extends ShellOptions | SpawnOptions>(options: T, defaultEnv?: EnvironmentVariables): T {
const defaultOptions = { ...options };
const execOptions = defaultOptions as SpawnOptions;
Expand Down Expand Up @@ -136,7 +138,13 @@ export function plainExec(
}
const stderr: string | undefined =
stderrBuffers.length === 0 ? undefined : decodeBuffer(stderrBuffers, encoding);
if (stderr && stderr.length > 0 && options.throwOnStdErr) {
if (
stderr &&
stderr.length > 0 &&
options.throwOnStdErr &&
// ignore this specific error silently; see this issue for context: https://github.com/microsoft/vscode/issues/75932
!(PS_ERROR_SCREEN_BOGUS.test(stderr) && stderr.replace(PS_ERROR_SCREEN_BOGUS, '').trim().length === 0)
) {
deferred.reject(new StdErrError(stderr));
} else {
let stdout = decodeBuffer(stdoutBuffers, encoding);
Expand Down

0 comments on commit 29bee00

Please sign in to comment.