Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Deploy code to micro:bit and removed need to rename file to deploy to CPX #233

Merged
merged 20 commits into from
Mar 4, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 1, 2020

Description:

  • Added functionality to deploy code to micro:bit
  • Added command for it, which must be enabled by enabling preview mode

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu changed the title WIP: deploy code to micro:bit Deploy code to micro:bit Mar 3, 2020
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on first try!

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job removing a lot of code 👍

@vandyliu vandyliu merged commit 0b7e5b4 into dev Mar 4, 2020
@vandyliu vandyliu deleted the users/t-vali/deploy-to-microbit branch March 4, 2020 00:00
@vandyliu vandyliu changed the title Deploy code to micro:bit Deploy code to micro:bit and removed need to rename file to deploy to CPX Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants