Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

More Venv Fixes + Dependency Fail Detect on Python #231

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

andreamah
Copy link
Contributor

Description:

Sorry for all of the Venv PR's, everyone 😥😥 !!

Venv fixes:

  • If you had a pre-existing extension-created venv but switched to another global interpreter, it wouldn't auto-point back to the extension-created venv.
  • Global interpreter wasn't properly switching when you configure a new environment within the same instance that you configured another one (ie: configured for global interpreter 1, but then switch to global interpreter 2 via command prompt or configuration switch detection -> global interpreter 1 would still be the one being used to run Python).

Python Improvements:
If you refuse to install any dependencies, running the code will now give a more helpful message (a suggestion from David in PR #228 !!).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Limitations:

Testing:

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@andreamah andreamah merged commit 6cf1ad6 into dev Feb 28, 2020
@andreamah andreamah deleted the users/t-anmah/info-python-dependency-fail branch February 28, 2020 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants