Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

re-organized structure for autocorrect #193

Merged
merged 19 commits into from
Feb 10, 2020

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Feb 6, 2020

Description:

Re-named and re-structured some of the code so that autocorrect on the user's code.py/main.py gives accurate results.

Also added docstring so the autocompletion describes functions.

Type of change

  • New feature (non-breaking change which adds functionality)

Limitations:

Testing:

  • src/microbit/test/*

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the docs update!

@andreamah
Copy link
Contributor Author

note: not merging this yet, since it will really impact PR #192 's file organization. We want to merge after #192 is merged.

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🍡

@andreamah andreamah merged commit 6b38fcc into dev Feb 10, 2020
@andreamah andreamah deleted the users/t-anmah/autocomplete-organizational-changes branch February 10, 2020 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants