Create Milestone #3686
Merged
Create Milestone #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
requested changes
Jul 5, 2022
src/github/pullRequestOverview.ts
Outdated
|
|
||
| const inputBox = vscode.window.createInputBox(); | ||
| inputBox.title = 'Create new milestone'; | ||
| inputBox.placeholder = 'New milestone name'; |
There was a problem hiding this comment.
I find the quick pick with the button/title bar without any title text to be a bit bare looking. Can you move the placeholder to the title?
alexr00
approved these changes
Jul 5, 2022
| }); | ||
|
|
||
| quickPick.show(); | ||
| quickPick.items = await getMilestoneOptions(this._folderRepositoryManager); |
There was a problem hiding this comment.
Just curious: why did you remove the quickPick.busy setting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on add milestone, a dropdown appears with all milestones. At the top right there is a plus which will create an inputbox where you can give the name of the new milestone. If you have already entered it and click on the plus (add), the inputbox appears with the text prefilled.