Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not activate review mode for closed or merged PR #3021

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

emtei
Copy link
Contributor

@emtei emtei commented Oct 5, 2021

Fixes #3009

Initially I tried to use line 312 this._prNumber = undefined; to disable review mode from previously branch, however with this.clear(true); all seems to work fine.

Probably that line should also be changed, but I'm not sure how to make pr "notResolved".

I tested manually those scenarios:

  1. Checkout branch with active PR (review activated) => checkout branch with merged PR (review NOT activated)
  2. Checkout branch with merged PR (review NOT activated) => checkout branch with merged PR (review NOT activated)
  3. Checkout branch with active PR (review activated) => checkout other branch with active PR (review activated for other PR)
  4. Open repository whose current branch is active with VSCode (review activated)
  5. Open repository whose current branch is closed with VSCode (review NOT activated)

@emtei
Copy link
Contributor Author

emtei commented Oct 19, 2021

@alexr00 Hello, can you review it please?

@alexr00 alexr00 added this to the November 2021 milestone Oct 19, 2021
src/view/reviewManager.ts Outdated Show resolved Hide resolved
@alexr00 alexr00 self-assigned this Nov 2, 2021
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I will merge after we have released the next version later this week.

@alexr00 alexr00 merged commit bc37d05 into microsoft:main Nov 4, 2021
@emtei emtei deleted the patch-1 branch November 22, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not associate branch with PR when PR is closed
2 participants