Comments don't show on non-checked out PR when closing and re-opening the file from the PRs veiw

[catskul]

When working on stacked PRs it's common to want to address comments on a lower PR in the stack while having the branch from a higher PR checked out.

At the moment it seems that GithubPullRequests extension will not allow this even when a PR file or diff is opened in preview mode from the Pull Requests sidebar.

IMO the comments should still appear in these editor windows at the very least, and ideally in any file with comments.

[catskul]

This might actually be a bug?

Sometimes I can see the comments and sometimes I cant see the comments when opening the file from the pull requests panel. (the editor says file_name.cc (Pull Request))

It seems like the first time I open the file after restarting VsCode, the comments are visible, but if I close and re-open the editor tab, they disappear and never come back until I restart vscode.

I've tried with both insiders (1.97.0-insider), and normal vscode (1.96.2) and have tried with both the release (0.102.0) and pre-release (0.103.2024121904) version of the vscode-github-pull-requests extension with no difference in behavior.

[alexr00]

It is a bug, and apparently it's been around for nearly a year. Thanks for reporting!

[alexr00]

To verify:

1. Install the latest pre-release version of GitHub Pull Requests
2. Open your clone of a GitHub repo in VS Code
3. Checkout branch A.
4. Create a new branch B and make a commit on branch B.
5. Create a pull request from branch B in to branch A.
6. Create a new branch C based on branch B.
7. Make a commit on branch C.
8. Create a pull request from branch C into branch B.
9. From the Pull Requests view, open code diffs from both the pull requests that you just created. Verify that you can leave comments in these files and that the comments get set on the correct PR.