Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Go to Next Diff in Pull Request" command fails with error #6237

Closed
TaldykinVyacheslav opened this issue Sep 19, 2024 · 2 comments · Fixed by #6563
Closed

"Go to Next Diff in Pull Request" command fails with error #6237

TaldykinVyacheslav opened this issue Sep 19, 2024 · 2 comments · Fixed by #6563
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2025

Comments

@TaldykinVyacheslav
Copy link

"Go to Next Diff in Pull Request" command fails with error

  • Extension version: 0.96.0
  • VSCode Version: 1.93.1
  • OS: Windows 11
  • Repository Clone Configuration (single repository/fork of an upstream repository): https://github.com/microsoft/vscode-pull-request-github
  • Github Product (Github.com/Github Enterprise version x.x.x): Gihub.com

Steps to Reproduce:

  1. Cloned https://github.com/microsoft/vscode-pull-request-github
  2. Created key binding for "GitHub Pull Requests: Go to Next Diff in Pull Request"
  3. Opened first file diff
  4. Pressed mentioned hotkey, expecting to be navigated to the next file with the diff
  5. Nothing happens, Current file isn't a pull request diff. error message pops up
    Screenshot 2024-09-19 170620
@TaldykinVyacheslav
Copy link
Author

Also, "Mark file as Viewed" is not opening next non-viewed file automatically. Is it intended behavior?

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2024
@alexr00
Copy link
Member

alexr00 commented Sep 26, 2024

Also, "Mark file as Viewed" is not opening next non-viewed file automatically. Is it intended behavior?

This is intended behavior, we don't open the next file.

@alexr00 alexr00 self-assigned this Dec 16, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 16, 2024
alexr00 added a commit that referenced this issue Dec 18, 2024
@alexr00
"Go to Next Diff in Pull Request" command fails with error
fd75c78 
Fixes #6237
@alexr00 alexr00 mentioned this issue Dec 18, 2024
Merged
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

"Go to Next Diff in Pull Request" command error microsoft/vscode-pull-request-github
3 participants
@TaldykinVyacheslav @eleanorjboyd @alexr00