Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added projects need separation #5792

Closed
hbons opened this issue Feb 28, 2024 · 7 comments · Fixed by #6548 or #6622
Closed

Added projects need separation #5792

hbons opened this issue Feb 28, 2024 · 7 comments · Fixed by #6548 or #6622
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish ux verified Verification succeeded
Milestone

Comments

@hbons
Copy link
Member

hbons commented Feb 28, 2024

When multiple projects are added in the Create view there's not separation between them:

image
@hbons hbons self-assigned this Feb 28, 2024
@alexr00 alexr00 assigned alexr00 and unassigned hbons Dec 16, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 16, 2024
alexr00 added a commit that referenced this issue Dec 16, 2024
@eleanorjboyd eleanorjboyd added the verification-steps-needed Steps to verify are needed for verification label Jan 28, 2025
@eleanorjboyd
Copy link
Member

what steps would be required to have multiple projects in the create view?

@alexr00
Copy link
Member

alexr00 commented Jan 29, 2025

To verify: Note: you don't actually need to create a PR, just mess around with the create view.

  1. Install the latest pre-release version of GitHub Pull Requests
  2. Have a Github repo that has multiple projects. The microsoft/vscode repo has this.
  3. Open the folder containing your clone of the GitHub repo in VS Code
  4. Run the command "Create Pull Request"
  5. In the title toolbar of the "Create" view, use the "Set Projects" action to bring up the project picker. You main need to provide additional auth to do this.
  6. Select multiple projects from the projects quick pick.
  7. Verify that they display nicely in the create view.

@alexr00 alexr00 removed the verification-steps-needed Steps to verify are needed for verification label Jan 29, 2025
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jan 29, 2025
@DonJayamanne
Copy link

I still do not see any separation, agreed its difficult to tell what each project is from this list, is it React or React Native or React Native Issues & PRs Python

Image

@DonJayamanne DonJayamanne reopened this Jan 29, 2025
@DonJayamanne DonJayamanne added verification-found Issue verification failed and removed verified Verification succeeded labels Jan 29, 2025
@alexr00
Copy link
Member

alexr00 commented Jan 30, 2025

Before there wasn't even a space between them, but I can see that it's still hard to read. I'll add a dot or something in between them.

alexr00 added a commit that referenced this issue Jan 30, 2025
@alexr00 alexr00 removed the verification-found Issue verification failed label Jan 30, 2025
@osortega
Copy link

In my opinion it might look better to make the ul flex-direction to be column so that each project is a single line and also add the dot to the first list entry.

Currently:
Image

Suggested:
Image

@TylerLeonhardt
Copy link
Member

@alexr00 I tried to verify this but the picker seems to only have one project... when I have 3

image image

@DonJayamanne DonJayamanne added the verified Verification succeeded label Jan 30, 2025
@TylerLeonhardt
Copy link
Member

image Actually I was able to verify in the vscode repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug polish ux verified Verification succeeded
Projects
None yet
6 participants