Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create suggestions from working tree changes #5256

Closed
nabeel-halo opened this issue Sep 20, 2023 · 2 comments · Fixed by #6153
Closed

Create suggestions from working tree changes #5256

nabeel-halo opened this issue Sep 20, 2023 · 2 comments · Fixed by #6153
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@nabeel-halo
Copy link

Hi, thanks for the extension, we love using it.

Wondering what we think of this as a feature. Currently, making a suggestion on a PR is a multi-step process. You highlight the line numbers you want to suggest, click the left "+" on the bottom of the lines, then make your edits without syntax highlighting or Intellisense support.

It would be cool if instead, we could make changes directly to the working tree (creating unstaged changes), and then have a way to "Add suggestions from working tree diff" (or something similar), where it goes through each of the diffs you've made and allows you to transform it into a suggestion with a comment.

This would particularly be helpful for making suggestions on larger PRs, and for making them much faster (just make the change and import rather than click-click-click-type).

Thanks again for creating a great tool :)

@alexr00 alexr00 self-assigned this Sep 20, 2023
@alexr00 alexr00 added the feature-request Request for new features or functionality label Sep 20, 2023
@alexr00 alexr00 added this to the Backlog milestone Sep 20, 2023
@alexr00
Copy link
Member

alexr00 commented Sep 20, 2023

This is a reasonable request, and would really add value over making a suggestion from github.com.

@alexr00 alexr00 modified the milestones: Backlog, October 2023 Sep 20, 2023
@alexr00 alexr00 modified the milestones: October 2023, November 2023 Oct 13, 2023
@alexr00 alexr00 modified the milestones: November 2023, December 2023 Nov 24, 2023
@alexr00 alexr00 modified the milestones: December 2023, On Deck Dec 5, 2023
@diminutivesloop
Copy link

This works in a limited sense already where if you add a suggestion to a line that already has working copy changes it will use the working copy change for the initial suggestion, however when I've done this the resulting diff for the suggestion isn't right. Instead of using the PR change as the "base" for the diff it appears to use the target branch instead which makes the content of the suggestion difficult to distinguish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants