-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot expand the electron 2 vscode PR #40
Comments
We ran into exceptions when dealing with file changes returned from GitHub. When a file or change is large, GitHub will not return the diff hunk for that change but we didn't protect that. |
There are several cases that GitHub pull request api doesn't return a file change with proper patches/diffs
For the first case, we can probably fetch the blob content from github, but we don't know for sure if we can open the binary content successfully in vscode. So for now we will open the file directly in browser. Reopen it and see if we can have enhancement from the api side. |
I also see this for a small PR: microsoft/vscode#73775 |
Closing since we should now handle file changes that don't have blob content by showing a notification to open them on GitHub |
microsoft/vscode#52782
The text was updated successfully, but these errors were encountered: