Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot expand the electron 2 vscode PR #40

Closed
Tyriar opened this issue Jun 26, 2018 · 5 comments
Closed

Cannot expand the electron 2 vscode PR #40

Tyriar opened this issue Jun 26, 2018 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality github Related to GitHub API

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

image

microsoft/vscode#52782

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2018
@rebornix
Copy link
Member

We ran into exceptions when dealing with file changes returned from GitHub. When a file or change is large, GitHub will not return the diff hunk for that change but we didn't protect that.

@kieferrm kieferrm added the github Related to GitHub API label Jun 27, 2018
RMacfarlane pushed a commit that referenced this issue Jul 10, 2018
@rebornix
Copy link
Member

rebornix commented Aug 8, 2018

There are several cases that GitHub pull request api doesn't return a file change with proper patches/diffs

  1. file or diff is too large
  2. file is binary

For the first case, we can probably fetch the blob content from github, but we don't know for sure if we can open the binary content successfully in vscode. So for now we will open the file directly in browser.

Reopen it and see if we can have enhancement from the api side.

@rebornix rebornix reopened this Aug 8, 2018
@rebornix rebornix added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Aug 8, 2018
@mjbvz
Copy link
Contributor

mjbvz commented May 17, 2019

I also see this for a small PR: microsoft/vscode#73775

Screen Shot 2019-05-17 at 9 59 29 AM

@RMacfarlane
Copy link
Contributor

@mjbvz 👍 this looks like #1059, sent out a fix for it

@RMacfarlane
Copy link
Contributor

Closing since we should now handle file changes that don't have blob content by showing a notification to open them on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality github Related to GitHub API
Projects
None yet
Development

No branches or pull requests

5 participants