This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Allow overriding basedir to fix web #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
approved these changes
Aug 9, 2022
|
Sadly this isn't good enough... because |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that this line that included
__dirnamewas always being injected even for web which caused failures.So this changes allows the ability to override what gets set there. So the webpack loader will see that it's building a web extension and inject
/instead... which will get removed here:https://github.com/microsoft/vscode-nls/blob/main/src/browser/main.ts#L43-L45