Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font settings #18536

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Fix font settings #18536

merged 9 commits into from
Jan 7, 2025

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Dec 20, 2024

Make default font family & font size = null, and adjust cell size accordingly for larger font sizes.

Example - font size 20:
Screenshot 2025-01-06 at 4 05 14 PM

Fixes #18351

Copy link

github-actions bot commented Dec 20, 2024

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.42% 50.48% $${\color{lightgreen} .06\% }$$
VSIX Size 12123 KB 12120 KB $${\color{lightgreen} -3 KB \space (0\%) }$$
Webview Bundle Size 3112 KB 3112 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@lewis-sanchez
Copy link
Contributor

Could you attach screenshots of the results pane respecting font family and font size settings?

@cssuh
Copy link
Member Author

cssuh commented Jan 6, 2025

This still needs some tweaking for font sizes 25 & up, will adjust this before I merge.

src/constants/constants.ts Outdated Show resolved Hide resolved
src/reactviews/pages/QueryResult/queryResultPane.tsx Outdated Show resolved Hide resolved
@cssuh cssuh merged commit 4ae32d4 into main Jan 7, 2025
6 checks passed
@cssuh cssuh deleted the chsuh/fontSettings branch January 7, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Query Results pane does not follow existing font size and font family settings
4 participants