Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizing some connection dialog code to prep for tests and next features #18527

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Reorganizing some connection dialog code to prep for tests and next features #18527

merged 3 commits into from
Jan 7, 2025

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Dec 19, 2024

  • Isolating some form- and azure-related functions to make them easier to test
  • simplifying how the state object handles defaults

@github-actions GitHub Actions
Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.35% 50.58% $${\color{lightgreen} .23\% }$$
VSIX Size 12120 KB 12122 KB $${\color{lightgreen} 2 KB \space (0\%) }$$
Webview Bundle Size 3112 KB 3112 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@Benjin Benjin merged commit a391186 into main Jan 7, 2025
6 checks passed
@Benjin Benjin deleted the dev/benjin/connectionDialogCleanup branch January 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasimkhan30 aasimkhan30 aasimkhan30 approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@cssuh cssuh Awaiting requested review from cssuh cssuh is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjin @aasimkhan30