Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prompt to create firewall rule if connection through dialog hits that. #18465

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Adding prompt to create firewall rule if connection through dialog hits that. #18465

merged 10 commits into from
Dec 4, 2024

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Dec 3, 2024

To do in follow-up PR: #18464

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 49.72% 49.64% $${\color{lightgreen} -.08\% }$$
VSIX Size 11714 KB 11715 KB $${\color{lightgreen} 1 KB \space (0\%) }$$
Webview Bundle Size 3108 KB 3108 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@Benjin Benjin merged commit 0a45a5e into main Dec 4, 2024
6 checks passed
@Benjin Benjin deleted the dev/benjin/firewall branch December 4, 2024 00:44
@Benjin Benjin mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasimkhan30 aasimkhan30 aasimkhan30 approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@cssuh cssuh Awaiting requested review from cssuh cssuh is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjin @aasimkhan30