Location of SymbolInformation gets lost when range is not defined #849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of microsoft/vscode#136618
location
ofSymbolInformation
is lost in the deprecatedvscode.SymbolInformation
constructor that is used here:vscode-languageserver-node/client/src/common/protocolConverter.ts
Lines 816 to 819 in 859a8ec
This is only a problem if
range
is not defined in which case vscode will not display the symbol in the symbol picker. Therange
needs to be falsy in order to use resolveWorkspaceSymbolTo override
resolveWorkspaceSymbol
, I used the following code:The updated constructor invocation should create exactly the same object as before: https://github.com/microsoft/vscode/blob/042a6e36a495db9830029d87c12dd9b65c7e3b47/src/vs/workbench/api/common/extHostTypes.ts#L1094-L1110