Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to client not ready error #764

Merged
merged 1 commit into from
May 11, 2021
Merged

Add more info to client not ready error #764

merged 1 commit into from
May 11, 2021

Conversation

yanmofeixi
Copy link
Contributor

I'm having trouble debugging my 'Language client is not ready yet'. Adding the method to help debug which request has caused this error.

@dbaeumer dbaeumer merged commit a5681d1 into microsoft:main May 11, 2021
@dbaeumer
Copy link
Member

Thanks.

A small tip: you should only send requests after client.onReady() got fullfilled.

@yanmofeixi
Copy link
Contributor Author

Thanks.

A small tip: you should only send requests after client.onReady() got fullfilled.

Yes. I have that in my language client, but I'm still seeing that. So I'm not sure which request type I have missed :) Thanks for quick approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants