Send workspace folder diff upon listener notification #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
force-pushed
the
451_send_early_wsfolder_changes
branch
from
280b5c0 to
f7ca6c1
Compare
|
Fixed lint errors |
dbaeumer
reviewed
Sep 17, 2019
client/src/workspaceFolders.ts
Outdated
| @@ -82,21 +92,40 @@ export class WorkspaceFoldersFeature implements DynamicFeature<undefined> { | |||
| id: id, | |||
| registerOptions: undefined | |||
| }); | |||
| this.sendInitialEvent(workspace.workspaceFolders); | |||
There was a problem hiding this comment.
To make this consistent with other feature (e.g. DidOpenTextDocumentFeature) could we send the extra event in the register hook. Then we always have the same code pathes.
|
@tsmaeder thanks for the PR. I have one minor request. See above. |
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for
Workspace folder changes are not sent to the server if they occur during initialisation #451
The gist of the fix is to remember the workspace folders sent to a language server during the "initialize" call and then send the diff between that state and the current WS folders when registering the workspace change listener.
Signed-off-by: Thomas Mäder tmader@redhat.com