Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isPreferred to the CodeAction protocol. #489

Closed
wants to merge 3 commits into from
Closed

Add isPreferred to the CodeAction protocol. #489

wants to merge 3 commits into from

Conversation

Jason3S
Copy link

@Jason3S Jason3S commented Apr 25, 2019

@msftclas
Copy link

msftclas commented Apr 25, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@Jason3S Jason3S mentioned this pull request Apr 25, 2019
Closed
@dbaeumer
Copy link
Member

For this to be merged we need to update the spec as well (see https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#L1). In addition I think this needs to be guarded by a client capability so the server can decided if it is worthwhile to compute the property (in this case inexpensive but this is how the spec works today).

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Apr 25, 2019
@Jason3S Jason3S mentioned this pull request Apr 28, 2019
Closed
@Jason3S
Copy link
Author

Jason3S commented Apr 29, 2019

I have updated the spec and I added isPreferred to the Code Action capabilities. I hope this is what you meant.

@Jason3S
Copy link
Author

Jason3S commented May 3, 2019

@dbaeumer Is there more I need to do?

rcjsuen
rcjsuen reviewed May 3, 2019
View reviewed changes
types/src/main.ts Outdated Show resolved Hide resolved
@dbaeumer dbaeumer removed the info-needed Issue requires more information from poster label May 9, 2019
@dbaeumer dbaeumer added this to the May 2019 milestone May 9, 2019
@Jason3S
Copy link
Author

Jason3S commented May 19, 2019

Just waiting on: Update specification.md Pull Request #736 · microsoft/language-server-protocol

@dbaeumer dbaeumer modified the milestones: May 2019, June 2019 Jun 4, 2019
@dbaeumer dbaeumer modified the milestones: June 2019, 3.15 Sep 10, 2019
@dbaeumer
Copy link
Member

Merged by hand with some minor modifications for consistency (e.g. isPreferredSupport).

@dbaeumer dbaeumer closed this Sep 17, 2019
@Jason3S Jason3S deleted the CodeAction.isPreferred branch October 22, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcjsuen rcjsuen rcjsuen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.
4 participants
@Jason3S @msftclas @dbaeumer @rcjsuen