Add setting for supporting pylance handling notebook intellisense #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Nov 2, 2021
| private onDidChangeConfiguration(event: ConfigurationChangeEvent) { | ||
| if ( | ||
| event.affectsConfiguration('jupyter.pylanceHandlesNotebooks') || | ||
| event.affectsConfiguration('python.languageServer') |
There was a problem hiding this comment.
This probably doesn't matter, but feasibly someone could change from "Pylance" to "Default" or vice versa, in which case the config changes from VS Code's view, but under the hood, the Python extension does nothing.
I doubt it really matters, but thought I'd mention.
Codecov Report
@@ Coverage Diff @@
## main #8140 +/- ##
=====================================
- Coverage 71% 71% -1%
=====================================
Files 366 366
Lines 22689 22606 -83
Branches 3445 3418 -27
=====================================
- Hits 16266 16197 -69
+ Misses 5012 5010 -2
+ Partials 1411 1399 -12
|
DonJayamanne
approved these changes
Nov 2, 2021
rchiodo
added a commit
that referenced
this pull request
Jan 13, 2022
rchiodo
added a commit
that referenced
this pull request
Jan 13, 2022
* Update package.json For #8140 * Fixup mock problem and ensure intellisense uses pylance in devmode * Fix host types * Fix metadata not being visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8076
Modify creation of the middleware portion to use the 'pylance' middleware based on a setting. Prerequisite for pylance to start on their own version of notebook intellisense