Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for semantic tokens in notebooks #8001

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Oct 21, 2021

Fixes #6799

Add support for performing semantic tokenization in the jupyter lsp middleware.

This requires a bunch of other changes too:
microsoft/vscode#135602
microsoft/vscode-python#17836

@rchiodo rchiodo requested a review from a team as a code owner October 21, 2021 22:48
@rchiodo rchiodo changed the title Rchiodo/semantic tokens Support for semantic tokens in notebooks Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #8001 (93b20e3) into main (02ca34d) will increase coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff          @@
##            main   #8001   +/-   ##
=====================================
  Coverage     70%     71%           
=====================================
  Files        364     365    +1     
  Lines      22379   22380    +1     
  Branches    3413    3412    -1     
=====================================
+ Hits       15815   15907   +92     
+ Misses      5179    5088   -91     
  Partials    1385    1385           
Impacted Files Coverage Δ
...atascience/notebook/intellisense/languageServer.ts 71% <0%> (ø)
src/client/datascience/types.ts 100% <ø> (ø)
...ence/notebook/intellisense/intellisenseProvider.ts 88% <94%> (+<1%) ⬆️
...atascience/interactive-window/interactiveWindow.ts 60% <100%> (-1%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 77% <0%> (-23%) ⬇️
.../client/datascience/interactive-window/identity.ts 64% <0%> (-22%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 67% <0%> (-11%) ⬇️
src/client/datascience/webviews/webviewHost.ts 77% <0%> (-2%) ⬇️
...datascience/editor-integration/cellhashprovider.ts 70% <0%> (-1%) ⬇️
... and 37 more

@rchiodo rchiodo merged commit 9c830c5 into main Oct 25, 2021
@rchiodo rchiodo deleted the rchiodo/semantic_tokens branch October 25, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants