Ignore load err that stops Python Ext from loading #5146
Conversation
| @@ -58,7 +60,19 @@ export async function activate(context: IExtensionContext): Promise<IExtensionAp | |||
| // We want to completely handle the error | |||
| // before notifying VS Code. | |||
| await handleError(ex, durations); | |||
| throw ex; // re-raise | |||
| traceError('Failed to active the Jupyter Extension', ex); | |||
There was a problem hiding this comment.
I'm pro this, as I'm big on not busting python. But just to ask. Does this make an odd customer case if they just have Jupyter installed? Like it just fails for the user without visual notification? Wondering about either only doing this if Python is installed or popping up a message (I'm assuming that the re-raise is what would usually show the message) so that the user at least knows what happened.
There was a problem hiding this comment.
uming that the re-raise is what would usually show the message) so that the user at least knows what happened.
I think its just to tell VS Code we failed.
await handleError(ex, durations);
this is where a message is displayed to the user today.
So if the extension fails to load they'll see a message (exiting code)
DonJayamanne
force-pushed
the
disableFailures
branch
from
9293fb0 to
aff61c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #5146 +/- ##
======================================
+ Coverage 71% 73% +2%
======================================
Files 402 402
Lines 26392 26403 +11
Branches 3798 3799 +1
======================================
+ Hits 18741 19446 +705
+ Misses 6091 5478 -613
+ Partials 1560 1479 -81
|
For #5145