Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify starting how we start local Jupyter, remote Jupyter and raw kernels (part 2) #13452

Closed
wants to merge 15 commits into from

Conversation

DonJayamanne
Copy link
Contributor

Part of #12832, #12831

Before (steps to start a kernel)

IJupyterNotebookProvider.connect(): connection
IJupyterNotebookProvider.createNotebook()               
   IJupyterServerProvider.getOrCreateServer()   
       IJupyterExecution.getServer()  
           ServerCache.getOrCreate(): INotebookServer
   INotebookServer.createNotebook()
       JupyterSessionManager.startNew(): Session

After (we now have clear and distinct classes with specific responsibilities)

IJupyterNotebookProvider.startJupyter(): connection
IJupyterSessionManagerFactory.create(connection): SessionManager 
JupyterSessionManager.startNew(): Session

@DonJayamanne DonJayamanne deleted the refactorRemotesPart2 branch November 28, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant