Do not trigger unnecessary environment changes #11819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
reviewed
Oct 26, 2022
| } | ||
| if (changed) { | ||
| this.didChangeInterpreters.fire(); | ||
| if (triggerChangeEvent) { |
There was a problem hiding this comment.
should this still also check changed?
There was a problem hiding this comment.
it looks like we're now just firing this event for every interpreter found
There was a problem hiding this comment.
No need, if you check the code, previously changed was initialize din line 498, all i've done is moved this code into the same if block, which was effectively the same, & there by removing the unnecessary variable as well
There was a problem hiding this comment.
I.e. it will not fire everytime, only when there are changes (where previously we'd set changed = true in the same if condition
amunger
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail safe for microsoft/vscode-python#20070