Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up the justMyCode setting to cell debugging #11689

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

roblourens
Copy link
Member

Fix #8146

@codecov-commenter
Copy link

Codecov Report

Merging #11689 (8b323e9) into main (0111a77) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #11689   +/-   ##
======================================
  Coverage     62%      62%           
======================================
  Files        483      483           
  Lines      34367    34416   +49     
  Branches    5573     5596   +23     
======================================
+ Hits       21562    21615   +53     
+ Misses     10741    10724   -17     
- Partials    2064     2077   +13     
Impacted Files Coverage Δ
src/notebooks/debugger/debuggingManager.ts 58% <100%> (+<1%) ⬆️
...otebooks/controllers/controllerPreferredService.ts 76% <0%> (-15%) ⬇️
src/kernels/common/commonFinder.ts 85% <0%> (-15%) ⬇️
...s/controllers/kernelRanking/kernelRankingHelper.ts 70% <0%> (-9%) ⬇️
src/kernels/installer/productInstaller.node.ts 74% <0%> (-5%) ⬇️
src/platform/common/utils/async.ts 49% <0%> (-2%) ⬇️
src/kernels/raw/finder/jupyterPaths.node.ts 78% <0%> (-1%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 72% <0%> (-1%) ⬇️
src/kernels/kernelDependencyService.node.ts 84% <0%> (-1%) ⬇️
src/platform/common/utils/misc.ts 82% <0%> (-1%) ⬇️
... and 12 more

@roblourens roblourens merged commit c4d5f39 into main Oct 18, 2022
@roblourens roblourens deleted the roblou/continued-perch branch October 18, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter cell debugging does not support "step into" the third party library code with "justmycode:false"
3 participants