Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more unused Python execution methods #11593

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Remove more unused Python execution methods #11593

merged 4 commits into from
Oct 10, 2022

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Oct 10, 2022 •
edited
Loading

Fixes #7583

  • Remove unused Python execution methods.

@DonJayamanne DonJayamanne marked this pull request as ready for review October 10, 2022 16:56
@IanMatthewHuff
Copy link
Member

@DonJayamanne Not entirely sure how the ordering is supposed to work on these PRs, but approving the removals on this one. Do they need to be looked at in order?

@DonJayamanne DonJayamanne force-pushed the step6RemoveUnUsedPythonExecMethods branch from ab78620 to f99156b Compare October 10, 2022 18:34
@DonJayamanne
Copy link
Contributor Author

Not entirely sure how the ordering is supposed to work on these PRs, but approving the removals on this one. Do they need to be looked at in order?

No need to look at them in any order,

@DonJayamanne DonJayamanne force-pushed the step6RemoveUnUsedPythonExecMethods branch 2 times, most recently from 11bc1b4 to 54edd64 Compare October 10, 2022 21:20
@DonJayamanne DonJayamanne force-pushed the step6RemoveUnUsedPythonExecMethods branch from 54edd64 to cef1958 Compare October 10, 2022 22:12
@DonJayamanne DonJayamanne force-pushed the step6RemoveUnUsedPythonExecMethods branch from cef1958 to f411c94 Compare October 10, 2022 22:24
@DonJayamanne DonJayamanne merged commit ac15cc9 into step5AddPtyhonEnvId Oct 10, 2022
@DonJayamanne DonJayamanne deleted the step6RemoveUnUsedPythonExecMethods branch October 10, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @IanMatthewHuff