Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle situation when remote connection is lost #11086

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Handle situation when remote connection is lost #11086

merged 3 commits into from
Aug 10, 2022

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10568
Fixes #9828

@DonJayamanne DonJayamanne requested a review from a team as a code owner August 10, 2022 06:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #11086 (5d92d40) into main (7d0dab5) will decrease coverage by 0%.
The diff coverage is 70%.

@@           Coverage Diff           @@
##            main   #11086    +/-   ##
=======================================
- Coverage     63%      63%    -1%     
=======================================
  Files        480      482     +2     
  Lines      33730    33860   +130     
  Branches    5500     5524    +24     
=======================================
+ Hits       21322    21394    +72     
- Misses     10376    10411    +35     
- Partials    2032     2055    +23     
Impacted Files Coverage Δ
src/kernels/kernelAutoReConnectMonitor.ts 67% <67%> (ø)
src/kernels/kernelAutoReConnectFailedMonitor.ts 68% <68%> (ø)
src/platform/common/utils/localize.ts 76% <75%> (-1%) ⬇️
src/kernels/common/baseJupyterSession.ts 80% <80%> (-1%) ⬇️
src/kernels/serviceRegistry.node.ts 95% <100%> (+<1%) ⬆️
src/platform/errors/errorUtils.ts 71% <100%> (-1%) ⬇️
src/platform/common/cancellation.ts 59% <0%> (-13%) ⬇️
src/kernels/raw/session/rawJupyterSession.node.ts 81% <0%> (-3%) ⬇️
src/kernels/jupyter/baseKernelConnectionWrapper.ts 35% <0%> (-3%) ⬇️
src/kernels/jupyter/jupyterKernelService.node.ts 74% <0%> (-2%) ⬇️
... and 7 more

@DonJayamanne DonJayamanne merged commit baeb825 into main Aug 10, 2022
@DonJayamanne DonJayamanne deleted the issue10568 branch August 10, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cell runs forever and can't interrupt if remote server is unavailable Cells interminable after server closed
3 participants