Update filter placeholder text (#8049)

microsoft · Oct 26, 2021 · cd7931d · cd7931d
1 parent 08f00b2
commit cd7931d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.nls.json b/package.nls.json
@@ -27,6 +27,7 @@
     "DataScience.installKernel": "The Jupyter Kernel '{0}' could not be found and needs to be installed in order to execute cells in this notebook.",
     "DataScience.newNotebookUI": "Welcome to VS Code's new notebook experience!  We think you'll find it faster and more pleasing to use. [Learn more...](https://aka.ms/NewNotebookUI)",
     "DataScience.customizeLayout": "Customize Layout",
+    "jupyter.kernel.filter.placeholder": "Choose the kernels that are available in the kernel picker.",
     "jupyter.kernel.category.jupyterSession": "Jupyter Session",
     "jupyter.kernel.category.jupyterKernel": "Jupyter Kernel",
     "jupyter.kernel.category.conda": "Conda Env",

diff --git a/src/client/common/utils/localize.ts b/src/client/common/utils/localize.ts
@@ -577,6 +577,10 @@ export namespace DataScience {
     export const serverNotStarted = localize('DataScience.serverNotStarted', 'Not Started');
     export const selectKernel = localize('DataScience.selectKernel', 'Change Kernel');
     export const selectDifferentKernel = localize('DataScience.selectDifferentKernel', 'Select a different Kernel');
+    export const kernelFilterPlaceholder = localize(
+        'jupyter.kernel.filter.placeholder',
+        'Choose the kernels that are available in the kernel picker.'
+    );
     export const selectDifferentJupyterInterpreter = localize(
         'DataScience.selectDifferentJupyterInterpreter',
         'Change Interpreter'

diff --git a/src/client/datascience/notebook/kernelFilter/kernelFilterUI.ts b/src/client/datascience/notebook/kernelFilter/kernelFilterUI.ts
@@ -6,6 +6,7 @@ import { IExtensionSyncActivationService } from '../../../activation/types';
 import { IApplicationShell, ICommandManager, IWorkspaceService } from '../../../common/application/types';
 import { disposeAllDisposables } from '../../../common/helpers';
 import { IDisposable, IDisposableRegistry, IPathUtils } from '../../../common/types';
+import { DataScience } from '../../../common/utils/localize';
 import { noop } from '../../../common/utils/misc';
 import {
     getKernelConnectionPath,
@@ -43,7 +44,7 @@ export class KernelFilterUI implements IExtensionSyncActivationService, IDisposa
         const duplicates = new Set<string>();
         let quickPickHidden = false;
         quickPick.canSelectMany = false;
-        quickPick.placeholder = 'Unselect items you wish to hide from the kernel picker';
+        quickPick.placeholder = DataScience.kernelFilterPlaceholder();
         quickPick.busy = true;
         quickPick.enabled = false;
 
@@ -83,7 +84,7 @@ export class KernelFilterUI implements IExtensionSyncActivationService, IDisposa
                 quickPick.matchOnDetail = true;
                 quickPick.sortByLabel = true; // Doesnt work, hence we sort manually.
                 quickPick.selectedItems = items.filter((item) => item.picked);
-                quickPick.placeholder = 'Unselect items you wish to hide from the kernel picker';
+                quickPick.placeholder = DataScience.kernelFilterPlaceholder();
                 quickPick.enabled = true;
                 quickPick.busy = false;
             })