update regex for new traceback format (#12197)

* re-enable tests * update regex for new traceback format
microsoft · Nov 29, 2022 · 959b937 · 959b937
1 parent 524aaef
commit 959b937
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/interactive-window/outputs/tracebackFormatter.ts b/src/interactive-window/outputs/tracebackFormatter.ts
@@ -72,7 +72,7 @@ export class InteractiveWindowTracebackFormatter implements ITracebackFormatter
         let executionCount: number | undefined;
         let location: string | undefined;
         const inputMatch = /^Input.*?\[.*32mIn\s+\[(\d+).*?0;36m(.*?)\n.*/.exec(traceFrame);
-        const cellMatch = /^Cell.*?\[.*32mIn\s+\[(\d+)\], (.*).\[0m\n/.exec(traceFrame);
+        const cellMatch = /^Cell.*?\[.*32mIn\s*\[(\d+)\], (.*).\[0m\n/.exec(traceFrame);
 
         if (inputMatch && inputMatch.length > 1) {
             executionCount = parseInt(inputMatch[1]);

diff --git a/src/test/datascience/interactiveWindow.vscode.common.test.ts b/src/test/datascience/interactiveWindow.vscode.common.test.ts
@@ -404,8 +404,7 @@ ${actualCode}
         await waitForTextOutput(notebookDocument!.cellAt(1), '1', 0, false);
     });
 
-    test.skip('Error stack traces have correct line hrefs with mix of cell sources', async function () {
-        // https://github.com/microsoft/vscode-jupyter/issues/12189
+    test('Error stack traces have correct line hrefs with mix of cell sources', async function () {
         const settings = vscode.workspace.getConfiguration('jupyter', null);
         await settings.update('interactiveWindowMode', 'single');
 
@@ -437,8 +436,7 @@ ${actualCode}
         assert.equal(hrefs?.length, 4, '4 hrefs not found in traceback');
     });
 
-    test.skip('Raising an exception from within a function has a stack trace', async function () {
-        // https://github.com/microsoft/vscode-jupyter/issues/12190
+    test('Raising an exception from within a function has a stack trace', async function () {
         const { activeInteractiveWindow } = await runNewPythonFile(
             interactiveWindowProvider,
             '# %%\ndef raiser():\n  raise Exception("error")\n# %%\nraiser()',