wip

microsoft · May 3, 2023 · 3cb7d1a · 3cb7d1a
1 parent edf15cb
commit 3cb7d1a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/kernels/jupyter/finder/remoteKernelFinder.ts b/src/kernels/jupyter/finder/remoteKernelFinder.ts
@@ -262,6 +262,7 @@ export class RemoteKernelFinder implements IRemoteKernelFinder, IDisposable {
 
     private async getRemoteConnectionInfo(displayProgress: boolean = true): Promise<IJupyterConnection | undefined> {
         const ui = new DisplayOptions(!displayProgress);
+        console.log(ui.disableUI);
         return this.jupyterConnection.createConnectionInfo({
             serverId: this.serverUri.serverId
         });

diff --git a/src/kernels/jupyter/serviceRegistry.node.ts b/src/kernels/jupyter/serviceRegistry.node.ts
@@ -62,6 +62,7 @@ import {
 import { IJupyterCommandFactory, IJupyterSubCommandExecutionService } from './types.node';
 import { RemoteKernelFinderController } from './finder/remoteKernelFinderController';
 import { KernelConnectionSessionCreator } from './launcher/kernelConnectionSessionCreator';
+import { JupyterKernelConnectionSessionCreator } from './launcher/jupyterKernelConnectionSessionCreator';
 
 export function registerTypes(serviceManager: IServiceManager, _isDevMode: boolean) {
     serviceManager.add<IJupyterCommandFactory>(IJupyterCommandFactory, JupyterCommandFactory);
@@ -126,6 +127,10 @@ export function registerTypes(serviceManager: IServiceManager, _isDevMode: boole
         IKernelConnectionSessionCreator,
         KernelConnectionSessionCreator
     );
+    serviceManager.addSingleton<JupyterKernelConnectionSessionCreator>(
+        JupyterKernelConnectionSessionCreator,
+        JupyterKernelConnectionSessionCreator
+    );
     serviceManager.addSingleton<IJupyterBackingFileCreator>(IJupyterBackingFileCreator, BackingFileCreator);
     serviceManager.addSingleton<IJupyterRequestCreator>(IJupyterRequestCreator, JupyterRequestCreator);
     serviceManager.addSingleton<IJupyterRequestAgentCreator>(IJupyterRequestAgentCreator, RequestAgentCreator);

diff --git a/src/kernels/jupyter/serviceRegistry.web.ts b/src/kernels/jupyter/serviceRegistry.web.ts
@@ -40,6 +40,7 @@ import {
 } from './types';
 import { RemoteKernelFinderController } from './finder/remoteKernelFinderController';
 import { KernelConnectionSessionCreator } from './launcher/kernelConnectionSessionCreator';
+import { JupyterKernelConnectionSessionCreator } from './launcher/jupyterKernelConnectionSessionCreator';
 
 export function registerTypes(serviceManager: IServiceManager, _isDevMode: boolean) {
     serviceManager.addSingleton<IJupyterNotebookProvider>(IJupyterNotebookProvider, JupyterNotebookProvider);
@@ -62,6 +63,10 @@ export function registerTypes(serviceManager: IServiceManager, _isDevMode: boole
         IKernelConnectionSessionCreator,
         KernelConnectionSessionCreator
     );
+    serviceManager.addSingleton<JupyterKernelConnectionSessionCreator>(
+        JupyterKernelConnectionSessionCreator,
+        JupyterKernelConnectionSessionCreator
+    );
     serviceManager.addSingleton<IJupyterBackingFileCreator>(IJupyterBackingFileCreator, BackingFileCreator);
     serviceManager.addSingleton<JupyterCommandLineSelector>(JupyterCommandLineSelector, JupyterCommandLineSelector);
     serviceManager.addSingleton<IJupyterServerProvider>(IJupyterServerProvider, NotebookServerProvider);