Skip to content

Commit

Permalink
Hook up the justMyCode setting to cell debugging
Browse files Browse the repository at this point in the history
Fix #8146
  • Loading branch information
roblourens committed Oct 18, 2022
1 parent 0111a77 commit 3014792
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/notebooks/debugger/debuggingManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class DebuggingManager
@inject(ICommandManager) commandManager: ICommandManager,
@inject(IApplicationShell) appShell: IApplicationShell,
@inject(IVSCodeNotebook) vscNotebook: IVSCodeNotebook,
@inject(IConfigurationService) private readonly settings: IConfigurationService,
@inject(IConfigurationService) private readonly configurationService: IConfigurationService,
@inject(IPlatformService) private readonly platform: IPlatformService,
@inject(IDebugService) private readonly debugService: IDebugService,
@inject(IServiceContainer) serviceContainer: IServiceContainer
Expand Down Expand Up @@ -268,11 +268,12 @@ export class DebuggingManager
mode: KernelDebugMode.Cell | KernelDebugMode.RunByLine,
cell: NotebookCell
) {
const settings = this.configurationService.getSettings(doc.uri);
const config: IKernelDebugAdapterConfig = {
type: pythonKernelDebugAdapter,
name: path.basename(doc.uri.toString()),
request: 'attach',
justMyCode: true,
justMyCode: settings.debugJustMyCode,
// add a property to the config to know if the session is runByLine
__mode: mode,
__cellIndex: cell.index
Expand Down Expand Up @@ -339,7 +340,7 @@ export class DebuggingManager
cell,
this.commandManager,
kernel!,
this.settings
this.configurationService
);
adapter.setDebuggingDelegate(controller);
this.notebookToRunByLineController.set(debug.document, controller);
Expand Down

0 comments on commit 3014792

Please sign in to comment.