Stricter tsconfig settings #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Oct 25, 2019
| @@ -398,7 +398,7 @@ export class Thread implements VariableStoreDelegate { | |||
| } | |||
|
|
|||
| this._pausedDetails = this._createPausedDetails(event); | |||
| this._pausedDetails[kPausedEventSymbol] = event; | |||
There was a problem hiding this comment.
Not sure how much refactoring you wanna do here, but this is a good use case for a WeakMap (and actually most WeakMap polyfills work almost the same way as the code does here--defining a non-enumerable symbol on the key objects 😛 )
connor4312
reviewed
Oct 25, 2019
| @@ -35,7 +35,7 @@ export function caseInsensitiveMerge<V>( | |||
| return {}; | |||
| } | |||
|
|
|||
| const out = {}; | |||
| const out: any = {}; | |||
There was a problem hiding this comment.
Suggested change
| const out: any = {}; | |
| const out: { [key: string]: V } = {}; |
should work
connor4312
reviewed
Oct 25, 2019
src/int-chrome/testSetup.ts
Outdated
| @@ -57,7 +57,7 @@ function formLaunchArgs( | |||
|
|
|||
| const argsWithDefaults = { ...chromeLaunchConfigDefaults, ...launchArgs }; | |||
| for (let k in argsWithDefaults) { | |||
| launchArgs[k] = argsWithDefaults[k]; | |||
| launchArgs[k] = (argsWithDefaults as any)[k]; // TODO@rob | |||
There was a problem hiding this comment.
TIL multiline suggestions aren't a thing, somehow, but
Object.assign(launchArgs, argsWithDefaults)
should do the trick without casts
connor4312
reviewed
Oct 25, 2019
| @@ -228,7 +228,7 @@ function createLaunchConfigFromContext( | |||
| dir += '/'; | |||
| } | |||
| } | |||
| config['preLaunchTask'] = 'tsc: build - tsconfig.json'; | |||
| (config as any)['preLaunchTask'] = 'tsc: build - tsconfig.json'; | |||
There was a problem hiding this comment.
You can probably add this as preLaunchTask?: string; in IMandatedConfiguration
connor4312
reviewed
Oct 25, 2019
src/targets/node/nodeLauncher.ts
Outdated
| @@ -323,7 +323,7 @@ function readEnvFile(file: string): { [key: string]: string } { | |||
| } | |||
|
|
|||
| const buffer = stripBOM(fs.readFileSync(file, 'utf8')); | |||
| const env = {}; | |||
| const env: any = {}; | |||
There was a problem hiding this comment.
Suggested change
| const env: any = {}; | |
| const env: { [key: string]: string } = {}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36
Adds a couple tsconfig rules. Some 'any' casts where the intent is not clear, some actual type fixes.