Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Check for presence of code executable instead of just folder #95

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Mar 4, 2018

This fixes the issue of running tests against both stable/insiders versions failing because the folder exists after one download but the executable is then missing for the next).

I can't see any automated tests for this but the vest way to manually test is:

  • Open terminal for an extension that has tests
  • Delete .vscode-test folder
  • Set CODE_VERSION to *
  • Run npm test
  • Ensure stable VS Code was downloaded and then used to execute tests
  • Set CODE_VERSION to insiders
  • Run npm test
  • Observe error message caused by trying to run Insiders code without downloading it

This change changes the exists check to look for the executable so that it will download the insiders version.

Note: This change does NOT handle a version mismatch between what's already in .vscode-test and what's available (I'll raise another issue about that, but that's less important than this IMO because it doesn't break the common case where you want to run tests in stable/insiders on Travis/AppVeyor because they start without a .vscode-test folder.

Fixes #94.

This fixes the issue of running tests against both stable/insiders versions failing because the folder exists after one download but the executable is then missing for the next).

Fixes microsoft#94.
@bpasero bpasero merged commit 3fd82d9 into microsoft:master Mar 6, 2018
@bpasero
Copy link
Member

bpasero commented Mar 6, 2018

Thanks 👍

@bpasero bpasero self-assigned this Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test script only checks for .vscode-test folder but not actual Code executable
2 participants