This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Check for presence of code executable instead of just folder #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of running tests against both stable/insiders versions failing because the folder exists after one download but the executable is then missing for the next).
I can't see any automated tests for this but the vest way to manually test is:
.vscode-test
folderCODE_VERSION
to*
npm test
CODE_VERSION
toinsiders
npm test
This change changes the exists check to look for the executable so that it will download the insiders version.
Note: This change does NOT handle a version mismatch between what's already in
.vscode-test
and what's available (I'll raise another issue about that, but that's less important than this IMO because it doesn't break the common case where you want to run tests in stable/insiders on Travis/AppVeyor because they start without a.vscode-test
folder.Fixes #94.