Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Honor npm config proxy settings #67

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Honor npm config proxy settings #67

merged 2 commits into from
Jun 27, 2017

Conversation

bvandre
Copy link
Contributor

@bvandre bvandre commented Jun 16, 2017

Pull request to solve issue #65

@bpasero
Copy link
Member

bpasero commented Jun 19, 2017

@bvandre thanks, good start. Would it make sense to also support npm_config_https_proxy if possible?

Also, there is another place where a request is being made: https://github.com/Microsoft/vscode-extension-vscode/blob/master/bin/test#L88

@bvandre
Copy link
Contributor Author

bvandre commented Jun 19, 2017

I updated to add a check to see if the protocol was https and to use the correct proxy value. I am not sure if we want to add a fallback to use npm_config_http if npm_config_https_proxy is not found or not.

@bpasero bpasero merged commit 6352382 into microsoft:master Jun 27, 2017
@bpasero
Copy link
Member

bpasero commented Jun 27, 2017

Thanks

@bpasero bpasero self-assigned this Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants