This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix #154 #170
Merged
Fix #154 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octref
commented
Apr 22, 2020
| options.proxy = process.env.npm_config_proxy; | ||
| } else if (process.env.npm_config_https_proxy && parsedUrl.protocol === 'https:') { | ||
| options.proxy = process.env.npm_config_https_proxy; | ||
| options.rejectUnauthorized = false; |
There was a problem hiding this comment.
See https://stackoverflow.com/questions/20433287/node-js-request-cert-has-expired. This is not the same effect but should be strong enough for our current use case.
bpasero
approved these changes
Apr 23, 2020
|
@octref this makes sense to me, we can archive the project once you merged and published the last version. My understanding is that newer extensions for a while now have not been depending on this module anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is pretty straightforward. I feel since we are closing the last issue, should we publish one last version 1.1.37 and then archive this repo?