Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorHoverWidget.foreground added #2281

Closed

Conversation

simaosilva
Copy link

Documentation for editorHoverWidget.foreground added. This has to do with the implementation of the issue found here

@gregvanl
Copy link

Hi @simaosilva Since this is documentation for an upcoming feature, can you move PR to the vscode-docs vnext branch? That way, it will be merged into the main docs when the feature is released in an upcoming milestone. Thanks.
Labeling as don't merge since this depends on a vscode PR.

@simaosilva simaosilva changed the base branch from master to vnext December 17, 2018 10:33
@simaosilva
Copy link
Author

HI @gregvanl. I've done that just now. Can you please check again?

@gregvanl
Copy link

@simaosilva Looks like you pulled in some other commits from vscode-docs master. I've updated the vnext branch. Can you try again so there is just your pending change? Thanks

@simaosilva simaosilva changed the base branch from vnext to master December 17, 2018 19:30
@simaosilva simaosilva changed the base branch from master to vnext December 17, 2018 19:30
@simaosilva
Copy link
Author

@gregvanl Ok. I updated the PR. Can you check it again?

@gregvanl
Copy link

gregvanl commented Feb 1, 2019

Closing for now since vscode product change hasn't been made yet. Feel free to reopen this PR once the vscode PR is accepted.

@gregvanl gregvanl closed this Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants