Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for code extensions path env var #1063

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Update doc for code extensions path env var #1063

merged 2 commits into from
Jul 3, 2017

Conversation

vazexqi
Copy link

@vazexqi vazexqi commented Jul 1, 2017

Also clarify what the defaults are.

See microsoft/vscode-extension-vscode#70. This change needs to be in tandem with that PR.

vazexqi added 2 commits July 1, 2017 12:56
Also clarify what the defaults are.

See microsoft/vscode-extension-vscode#70. This change needs to be in tandem with that PR.
If it is a TypeScript extension, it defaults to `process.cwd()/out/test`.
If it is a JavaScript extension, it defaults to `process.cwd()/test`.
@msftclas
Copy link

msftclas commented Jul 1, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@gregvanl gregvanl merged commit 8beacec into microsoft:master Jul 3, 2017
vazexqi added a commit to forcedotcom/salesforcedx-vscode that referenced this pull request Jul 3, 2017
I submitted two PRs to allow for the tests to specify an extensions folder as well.

microsoft/vscode-extension-vscode#71
microsoft/vscode-docs#1063
vazexqi added a commit to forcedotcom/salesforcedx-vscode that referenced this pull request Jul 3, 2017
I submitted two PRs to allow for the tests to specify an extensions folder as well.

microsoft/vscode-extension-vscode#71
microsoft/vscode-docs#1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants