Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications colors to Theme Color Reference #1038

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

akamud
Copy link

@akamud akamud commented Jun 13, 2017

Add documentation to new features added in microsoft/vscode#28471

@msftclas
Copy link

@akamud,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@gregvanl
Copy link

Hi @akamud, since the feature is not yet in the stable build, we shouldn't merge this doc change into master yet. There are two options: sit on the PR until the next stable release or move this PR to the vscode-docs vnext branch. The vnext branch is where we do prerelease documentation and the commits are merged to vscode-docs master at the time of the release.

@akamud
Copy link
Author

akamud commented Jun 13, 2017

I'll rebase this on vnext then. Thanks!

@gregvanl
Copy link

Great, Thanks

@akamud akamud force-pushed the notification-colors branch from 102a6de to 1b4bd7a Compare June 13, 2017 20:06
@akamud akamud changed the base branch from master to vnext June 13, 2017 20:06
@akamud
Copy link
Author

akamud commented Jun 13, 2017

Done!

@gregvanl gregvanl merged commit 6cb2744 into microsoft:vnext Jun 13, 2017
@gregvanl
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants