Docker Explorer 2.0

[ejizba]

Summary

I set out with the goal to move the Docker explorer over to the shared tree implementation used by our other extensions. It was a bit more of a ...massive... undertaking than I expected because I basically had to tear everything down and rebuild it. In the end, I think I fixed a lot of bugs and improved a lot of things, but most importantly this codebase will be much easier for us to maintain because it's now based on our shared building blocks.

We are going to need to have people (on our team and hopefully outside of our team) bash against this for a little while before releasing. With that in mind, any time spent reviewing this is much appreciated!

Help Wanted! Please follow these instructions to install the latest build from master and let us know what you think!

THE NEW EXPLORER

It features separate views for containers/images/registries - which means you can hide/resize/reorder each view on its own.

It also has in-line error messages when failing to connect, which IMO is much better than that big scary error message we used to have.

THE NEW COMMAND PALETTE

Just like the above, the commands are all grouped based on images/containers/registries. It will also be a one-to-one mapping of the tree. So if you have the tree grouped/sorted/etc., you will see that when running from the command palette.

Since Docker previously had the option for "All Containers", I wanted to maintain and improve on that functionality. Now you will see a multi-select quick pick:

THE NEW ACR TASK VIEW

The old way of viewing tasks was through a web view that honestly wasn't accessible, wasn't consistent with other VS Code experiences, and was going to be annoying to maintain going forward. I moved all tasks into the tree. You can still view properties, copy image digest, and view logs - but you can't write a custom filter for viewing tasks. I still think this is a net-positive experience and we can theoretically add back support for filtering in this new world.

More detailed list of fixes

Leverage tree from shared package

• Subscription filter button: Fixes Add subscription filter to Azure node in tree #512
• Add "Deploy to Azure" in command palette: Fixes "Deploy Image to Azure App Service" is not available through command palette #551
• Support "Load more...": Fixes Incomplete image listing for private registry (support Load More) #799
• Don't use node.label: Fixes Stop using node.label in the codebase to mean the container/image/etc name #842
• Fix excessive docker polling: Fixes Excessive Docker polling #959
• Use multi-select quick pick for commands like start/stop/remove: Related to Support for multiple selection of items and actions on these items (batch) #331
• Show task logs in the tree instead of a webview. Fixes There are no tooltips when hovering on the icons in the Logs window #661, Fixes There opens a new tab when executing the action 'View Task Logs' every time  #937, Fixes [Theme]Hard to see the digest #853, and Fixes Incorrect icon for open log in View Azure Logs, and where's the copy button? #641

Leverage wizard from shared package

• Incorrect wizard step count: Fixes Incorrect wizard step when deploying images to app service #442
• Consistently use ignoreFocusOut: Fixes App service code base - fix ignoreFocusOut #810
• Use async validation of web app name: Fixes App service name validation - use modal async validation instead of warning message #809
• Use ext.ui.showQuickPick everywhere: Fixes Use ext.ui.showQuickPick everywhere #355

Leverage consistent error handling/telemetry from shared package

• dockerHubUtils isn't properly handling errors: Fixes dockerHubUtils handling errors: Cannot read map of undefined #885
• Wasn't showing errors when failed to log in to Docker Hub: Fixes We don't show errors when unable to log into Docker Hub #360
• Confusing error when pulling images: Fixes [Mac]Show a confused error when attempting to pull images from azure #549

Other:

• Better handle expired credentials for Docker Hub: Fixes We should better handle expired credentials for Docker Hub #935 and Fixes Please log out of Docker Hub and then log in again. #882
  • We were saving the token, username, and password in keytar, but never using the username/password again. Rather than saving/re-using a token that is likely to expire, we should actually leverage the username/password from keytar and get a new token.
• Show organizations in Docker Hub tree: Fixes Docker Explorer: Docker Hub Organization Repositories #466
• Add "Start Container...": Fixes Restart container returns 500 error #279
• Add prune command for just images or just containers: Fixes Prune all in category with right click menu #789
• Add confirmation message before all destructive actions: Fixes Please add the confirmation before Remove container!!! #948
• Add pull option for repositories and tags in ACR: Fixes Add "Pull" menu option for repositories and tags in a container registry #382
• Make naming of tag/image more consistent: Fixes Change the action 'Pull Tag from Azure' to 'Pull Image from Azure' on context menu #837, Fixes Casing of 'Pull tag from Azure' is wrong #775, and Fixes Only display the image's tag when trying to run 'Delete Azure Image' command #491
• Move to shared library: Fixes Move to shared library #372

[eine]

I'm trying 0.6.3-alpha from https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=6664 on Win10 with VSC:

Version: 1.35.1 (user setup)
Commit: c7d83e57cd18f18026a8162d042843bda1bcf21f
Date: 2019-06-12T14:30:02.622Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

THE NEW EXPLORER

This is great. I was wondering if there was anything wrong with my setup before I saw this '2.0' issue.

It also has in-line error messages when failing to connect

This works ok. I restarted docker-for-win, to test it. Both showing the messages and automatically reconnecting again.

Just like the above, the commands are all grouped based on images/containers/registries.

This is great too.

Since Docker previously had the option for "All Containers", I wanted to maintain and improve on that functionality. Now you will see a multi-select quick pick:

I don't know if this is the desired behaviour, but I found myself trying it multiple times until I guessed it:

• F1
• Docke Cont Start
• Enter
• ArrowDown
• Enter

Nothing happens. Due to the checkbox, the last 'Enter' has no effect, although I 'selected' a container with the arrow key. For it to work, I need to press 'Space' before the last 'Enter'. This will select the container.

I'd say that requiring to press 'space' is unnecessary when the users want to start/stop/whatever a single container.

Note that this does not apply if you do some of the steps with the mouse, because clicking on a container will select it only.

THE NEW ACR TASK VIEW

I am not a user of ACR.

[ejizba]

@1138-4eb thanks for the feedback!

Regarding the space bar vs. enter - that confused me as well when I first tried it. Created a new issue here: #1005