Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registries V2 #4026

Merged
merged 46 commits into from
Sep 21, 2023
Merged

Registries V2 #4026

merged 46 commits into from
Sep 21, 2023

Conversation

alexyaang
Copy link
Member

@alexyaang alexyaang commented Aug 8, 2023 •
edited
Loading

TODO: (in no particular order)

Existing commands that needs to be re-written

  • Make all generic registries commands work
    • connectRegistry
    • copyRemoteImageDigest
    • copyRemoteFullTag
    • deleteRemoteImage
    • deployImageToAzure
    • deployImageToAca
    • disconnectRegistryProvider
    • registryHelp
    • logInToDockerCli
    • logOutOfDockerCli
    • pullImageFromRepository
    • pullRepository
    • pushImage
    • reconnectRegistry
  • MakedockerHub commands work
    • openDockerHubInBrowser
  • Make all Azure commands work
    • buildImageInAzure
    • createAzureRegistry
    • deleteAzureRegistry
    • deleteAzureRepository
    • openInAzurePortal
    • untagAzureImage
    • viewAzureProperties

New commands

  • Make/Confirm these commands work on Github Registries
    • pushImage
    • copyRemoteFullTag
    • copyRemoteImageDigest

User Experience

  • Make registryExperience() better so that users only get prompted if a the command is possible on a certain registry provider
  • Add paging in extensibility package
  • In AzureRDP, add a "fire soon" analogue
  • Simplify context values Registries V2 #4026 (comment)
  • Recognize CancellationError as a cancellation error in azext-utils package
  • Release azext-utils package v-2.1.1

External things:

@alexyaang
Registries V2 (#4021)
3b2ee0f 
* saving progress

* added context values for copy full tag

* added back copy remote image digest

* comment out commands that are not implemented yet

* added disconnext registry function back

* small fixes to adjust to new changes
@alexyaang
Made Some ACR Commands Work (#4027)
008e9bf 
* adjusted scheduleRunReuqest to work with new registries tree

* delete azure repository command implementation

* actually added back delete azure repository

* added back delete Azure Registry command

* changed registry tree util file name to be more general

* added openInAzurePortalCommand
@alexyaang alexyaang changed the title Registries V2 (#4021) Registries V2 Aug 9, 2023
@alexyaang alexyaang mentioned this pull request Aug 10, 2023
Merged
1 task
@alexyaang
Added Back createAzureRegistry command (#4029)
e090fb4 
* adjusted scheduleRunReuqest to work with new registries tree

* delete azure repository command implementation

* actually added back delete azure repository

* added back delete Azure Registry command

* changed registry tree util file name to be more general

* added openInAzurePortalCommand

* added back create azure registry command

* move createAzureClient to azureUtils
@alexyaang alexyaang mentioned this pull request Aug 10, 2023
Merged
4 tasks
@alexyaang @bwateratmsft
Added More Commands Back (#4031)
bdac083 
* adjusted scheduleRunReuqest to work with new registries tree

* delete azure repository command implementation

* actually added back delete azure repository

* added back delete Azure Registry command

* changed registry tree util file name to be more general

* added openInAzurePortalCommand

* added back create azure registry command

* move createAzureClient to azureUtils

* added viewAzureProperties command back (partially)

* small tweak to make build image in azure work

* added untag azure image commad

* added logout of docker cli command

* add case sensitivity operator to be consistent

* Update src/tree/registries/Azure/AzureRegistryDataProvider.ts

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* added void

* removed symbol as it already exists

---------

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
@alexyaang alexyaang mentioned this pull request Aug 11, 2023
Merged
1 task
@alexyaang @bwateratmsft
Added Back Open Docker Hub Item in Browser (#4033)
c967595 
* added view docker hub item in browser command

* updated npm package

* Added More Commands Back (#4031)

* adjusted scheduleRunReuqest to work with new registries tree

* delete azure repository command implementation

* actually added back delete azure repository

* added back delete Azure Registry command

* changed registry tree util file name to be more general

* added openInAzurePortalCommand

* added back create azure registry command

* move createAzureClient to azureUtils

* added viewAzureProperties command back (partially)

* small tweak to make build image in azure work

* added untag azure image commad

* added logout of docker cli command

* add case sensitivity operator to be consistent

* Update src/tree/registries/Azure/AzureRegistryDataProvider.ts

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* added void

* removed symbol as it already exists

---------

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* minor tweak to avoid index out of bounds

* use built in methods to determine the type of item

---------

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
This was referenced Aug 11, 2023
Merged
Merged
Merged
Merged
@alexyaang
Added Back pushImage() (#4034)
6df7928 
* make pushImage work

* added getAllRegistries command

* added getLoginInformation()

* account for cases where registry in undefined

* added filtering to make get all registries more optima

* added logic to filter github repositories
@alexyaang alexyaang mentioned this pull request Aug 22, 2023
Merged
@alexyaang
Added Back Azure Deploy to ACA & Azure Deploy to AAS (#4038)
ea8f0bc 
* added back basic implementation of deploy ACA

* saving progress

* added step for selecting subscriptions

* small tweaks

* progress on deploy image to azure app service

* improved azure subscription selection experience

* actually made deploy image to AAS work

* remove accidetal change to settings.json

* fix small mistake

* fixed more mistakes

* fix more mistakes

* fixed even more mistakes...
This was referenced Aug 23, 2023
Merged
Merged
@alexyaang
Implemented Delete Remote Image for GenericV2 (#4039)
96b1a21 
* added logic for copy remote imgage digest

* added back delete image

* refined logic for delete image

* fixed pushImage

* reverted changes to registryExperience

* tag logic for GitHub

* be able to debug github image

* added back skipIfOne flag
This was referenced Aug 25, 2023
Merged
Merged
Merged
@alexyaang
Added Untag Image Command for Azure RDP (#4041)
6d10af1 
* adjusted context values

* added untag Image

* remove github option for delete tag

* commtag -> v2tag

* slighty changed context values
@alexyaang alexyaang mentioned this pull request Aug 25, 2023
Merged
@alexyaang @bwateratmsft
Improve UX for Connecting & Disconnecting Generic V2 Registries (#4043)
e03bb57 
* added remove tracked registry command

* added command to add generic v2 registry

* Update package.nls.json

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

* Update package.nls.json

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>

---------

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
@alexyaang alexyaang mentioned this pull request Aug 29, 2023
Merged
@alexyaang
added logic for reconnect (#4045)
befa438
@alexyaang
Cleanup Registries Implementation (#4046)
a187269 
* fixed genericV2 pull image bug

* improved utils to use outside methods

* enable copyImageDigest for all v2 registries

* removed run task & did TODOs

* did TODOs
@alexyaang
use baseUrl
b49d849
alexyaang

This comment was marked as outdated.

Sign in to view

@alexyaang alexyaang mentioned this pull request Sep 8, 2023
Merged
@alexyaang alexyaang mentioned this pull request Sep 11, 2023
Merged
@alexyaang
Added fire soon function to AzureRDP (#4066)
51e8fa9 
* added fire soon

* clear time out
@alexyaang alexyaang mentioned this pull request Sep 14, 2023
Merged
@alexyaang
Change fireSoon to take callback function (#4071)
4e6aa8a 
* change firesoon to take callback function

* use RDP label when determining type of registry
@alexyaang
use new RegistryV2RequestOptions for azure requests
d3da812
@alexyaang alexyaang mentioned this pull request Sep 18, 2023
Merged
2 tasks
alexyaang and others added 6 commits September 19, 2023 09:47
@alexyaang @bwateratmsft
Improve Registry Experience & Simplify Context Values (#4076)
fbceb92 
* added implementation

* added comments

* use RegistryQuickPickStep for everything

* fix regex

* fix viewproperties context value package json

* remove unnecessary method

* added back necessary logic

* Commit current progress

* Commit current progress

* adjust package.json

* fix azure typo

* preserve existing additional context value

* make regex more robust

---------

Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
@alexyaang
remove unnecessary comment
5dd3dfb
@alexyaang
uploaded & changed azext package version
6bb9eca
@bwateratmsft
Asynchronously fetch createdAt info (#4074)
34e5b00
@bwateratmsft
Add registry extensibility capability (#4061)
fa2bb67
@alexyaang
remove generic v2 root if it's the last one
7b831f4
@alexyaang
Copy link
Member Author

alexyaang commented Sep 20, 2023 •
edited
Loading

I'm going to test the functionality one more time before we merge to main:

  • Make all generic registries commands work
    • connectRegistry
    • copyRemoteImageDigest
    • copyRemoteFullTag
    • deleteRemoteImage
    • deployImageToAzure
    • deployImageToAca
    • disconnectRegistryProvider
    • registryHelp
    • logInToDockerCli
    • logOutOfDockerCli
    • pullImageFromRepository
    • pullRepository
    • pushImage
    • reconnectRegistry
  • MakedockerHub commands work
    • openDockerHubInBrowser
  • Make all Azure commands work
    • buildImageInAzure
    • createAzureRegistry
    • deleteAzureRegistry
    • deleteAzureRepository
    • openInAzurePortal
    • untagAzureImage
    • viewAzureProperties
  • Generic V2 Registries
    • add registry
    • remove tracked registry

@bwateratmsft bwateratmsft mentioned this pull request Sep 21, 2023
Closed
@alexyaang alexyaang merged commit f5e45c6 into main Sep 21, 2023
2 checks passed
@alexyaang alexyaang deleted the yangalex/registries branch September 21, 2023 13:16
@microsoft microsoft locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use shared auth package for azure auth instead of Azure Account extension Support third-party registries
2 participants
@alexyaang @bwateratmsft