Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-select to context menu commands that most need it #1623

Merged
merged 7 commits into from
Feb 18, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Feb 13, 2020

Fixes #331, fixes #1453.

This PR is similar to #1620 (and also covers what #1494 does) but adds multi-select support to all of the explorer groups (except Registries), with multi-select support for the following commands:

Containers, Images, Networks, Volumes: Remove
Containers only: Start, Stop, Restart

It also will filter off nodes for which the action taken is not eligible (for example, parent nodes, or stopping an already-stopped container). Unfortunately it shows actions for whatever was the specific item in the selection set that was right-clicked (not actions that are valid for all selected items) but we think that for the most part that will not be an issue.

Some of the remaining commands do not make sense as a multi-select (for example, Image > Copy full tag), some of the others maybe make sense but we are leaving them as single-select at this time (for example, Inspect).

@bwateratmsft bwateratmsft added this to the 0.11.0 milestone Feb 13, 2020
@bwateratmsft bwateratmsft requested a review from a team as a code owner February 13, 2020 16:56
@bwateratmsft bwateratmsft self-assigned this Feb 13, 2020
@eine
Copy link

eine commented Feb 17, 2020

Some of the remaining commands do not make sense as a multi-select (for example, Image > Copy full tag), some of the others maybe make sense but we are leaving them as single-select at this time (for example, Inspect).

If this is applied, I'd request to please NOT close #331 as part of this PR.

@bwateratmsft
Copy link
Collaborator Author

Some of the remaining commands do not make sense as a multi-select (for example, Image > Copy full tag), some of the others maybe make sense but we are leaving them as single-select at this time (for example, Inspect).

If this is applied, I'd request to please NOT close #331 as part of this PR.

I think it would be appropriate to close #331 but create a new one for Inspect/View Logs/etc.). This would help us gauge the importance of taking such a change.

@bwateratmsft bwateratmsft merged commit 672bd0e into master Feb 18, 2020
@bwateratmsft bwateratmsft deleted the bmw/multiselect branch February 18, 2020 16:01
@bwateratmsft bwateratmsft removed their assignment Feb 18, 2020
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "start all containers" option Support for multiple selection of items and actions on these items (batch)
4 participants